Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/config-policy-controller: #242, #239 #866

Merged
merged 2 commits into from
May 15, 2024

Conversation

yiraeChristineKim and others added 2 commits May 15, 2024 19:47
The "hosting cluster" should be used for the Policy, OperatorPolicy, and compliance events
Ref: https://issues.redhat.com/browse/ACM-11255
Signed-off-by: yiraeChristineKim <yikim@redhat.com>
(cherry picked from commit a2ebc6b)
Previously, the operator policy controller would list all InstallPlans
in the subscription namespace and filter down to ones it considered
relevant. Among other things, it used OwnerReferences to do this
filtering, but those are inconsistently applied by OLM.

Now, it only looks at InstallPlans labelled specifically for the
subscription in the policy, which seems to be much more reliably set and
updated by OLM. Generally, only one InstallPlan will have the label,
which makes it more possible to unambiguously assign a compliance to it
based on its phase (previously, it was unclear what to assign to
"historic" InstallPlans).

Much of the controller logic still handles the possibility of there
being multiple relevant InstallPlans, for robustness.

Refs:
 - https://issues.redhat.com/browse/ACM-11025

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit c636d7d)
Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign dhaiducek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented May 15, 2024

@magic-mirror-bot magic-mirror-bot bot merged commit f1f4286 into main May 15, 2024
12 of 13 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1715802467527 branch May 15, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants